Do not synchronize `ApplicationContext` creation in the TestContext framework [SPR-10536]

[spring-projects-issues]

James Shaw opened SPR-10536 and commented

DefaultCacheAwareContextLoaderDelegate.loadContext() synchronizes access to the ContextCache which means that ApplicationContexts cannot be initialized in parallel.

I tried removing the ContextCache altogether, but this uncovered a deadlock in AbstractBeanFactory. Trying to fix that with a shared lock caused some race condition to autowire a null Environment into a @Configuration class' field.

---

Affects: 3.2.2

Issue Links:

• No bean of type ConfigurableEnvironment in AbstractTestNGSpringContextTests [SPR-14834] #19400 No bean of type ConfigurableEnvironment in AbstractTestNGSpringContextTests
• ApplicationContext fails to load in TestNG test if previous test is annotated with @DirtiesContext [SPR-12918] #17517 ApplicationContext fails to load in TestNG test if previous test is annotated with @DirtiesContext
• Allow for concurrent test execution in the TestContext framework [SPR-5863] #10532 Allow for concurrent test execution in the TestContext framework

1 votes, 3 watchers

[spring-projects-issues]

Sam Brannen commented

This issue is closely related to #10532.