AnnotationUtils fails to retrieve attribute values from non-public annotations [SPR-11104]

[spring-projects-issues]

Sam Brannen opened SPR-11104 and commented

Status Quo

The getValue() methods in AnnotationUtils currently fail to retrieve the value of the desired annotation attribute if the annotation itself is not public (i.e., package private). In contrast, the getDefaultValue() methods work fine since they invoke Method#getDefaultValue(). Thus the problem lies with the fact that AnnotationUtils.getValue(Annotation, String) attempts to invoke the method, swallowing the exception on failure and silently returning null.

Deliverables

1. Update AnnotationUtils.getValue(Annotation, String) so that it uses reflection to make the desired annotation attribute method accessible before invoking it to retrieve the value.

---

Affects: 3.0 GA

Issue Links:

• Support meta-annotation attribute overrides in the TestContext framework [SPR-11038] #15666 Support meta-annotation attribute overrides in the TestContext framework ("is depended on by")

Referenced from: commits b830d73

[spring-projects-issues]

Sam Brannen commented

Resolved as discussed in the comments for GitHub commit b830d73:

Support non-public anno. attr. values in AnnoUtils

Prior to this commit, the getValue(Annotation, String) method in
AnnotationUtils failed to retrieve the value of the desired annotation
attribute if the annotation itself was not public -- for example if the
annotation was declared as package private.

This commit addresses this issue by ensuring that getValue(Annotation,
String) uses reflection to make the desired annotation attribute method
accessible before attempting to invoke it to retrieve the value.