Validate method parameter index via Java 8 Method.getParameterCount() [SPR-13456]

[spring-projects-issues]

俞火江 opened SPR-13456 and commented

If the value for parameterIndex is too great when constructing a MethodParameter, an ArrayIndexOutOfBoundsException will be thrown later when some method such as getParameterType() is called. So why not detect the error as early as possible?

---

Affects: 4.2.1

Issue Links:

• Introduce support for creating a MethodParameter from a Java 8 Parameter [SPR-14055] #18627 Introduce support for creating a MethodParameter from a Java 8 Parameter

Referenced from: commits 39e3f2e

[spring-projects-issues]

Juergen Hoeller commented

The main reason why we are not checking a parameter index early is the inefficiency of Method.getParameterTypes() which copies the Class array every time: If we are just calling this for determining the parameter count, it's quite a waste. However, as of Java 8, there is Method.getParameterCount() as a much more efficient variant for that purpose. We'll use this across the codebase as of Spring Framework 5.0.

Juergen

[spring-projects-issues]

俞火江 commented

Quite reasonable

[spring-projects-issues]

Juergen Hoeller commented

Fixed along with #18627.