Skip to content

Add a warning to AnnotationReadingVisitorUtils #23408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marekkrk wants to merge 1 commit into from
Closed

Add a warning to AnnotationReadingVisitorUtils #23408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...c/main/java/org/springframework/core/type/classreading/AnnotationReadingVisitorUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
import java.util.Map;
import java.util.Set;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;

import org.springframework.asm.Type;
import org.springframework.core.annotation.AnnotationAttributes;
import org.springframework.core.annotation.AnnotationUtils;
Expand All @@ -45,6 +48,8 @@
@Deprecated
abstract class AnnotationReadingVisitorUtils {

private static final Log logger = LogFactory.getLog(AnnotationReadingVisitorUtils.class);

public static AnnotationAttributes convertClassValues(Object annotatedElement,
@Nullable ClassLoader classLoader, AnnotationAttributes original, boolean classValuesAsString) {

Expand Down Expand Up @@ -94,7 +99,8 @@ else if (value instanceof Class[]) {
}
entry.setValue(value);
}
catch (Throwable ex) {
catch (Exception ex) {
logger.warn("Cannot convert class values", ex);
// Class not found - can't resolve class reference in annotation attribute.
result.put(entry.getKey(), ex);
}
Expand Down