Response body available in both message and exception - #24637
Closed
nbaars wants to merge 1 commit into
Closed
Conversation
|
@nbaars Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@nbaars Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
rstoyanchev
added
in: web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observation
When the status code is unknown a message will be constructed but the thrown exception does not contain the body anymore.
Wanted behavior
The
UnknownHttpStatusCodeException.getResponseBodyAsString()returns the body and does not return""Fix
Same as the method
protected void handleError(ClientHttpResponse response, HttpStatus statusCode)assign the body to a local variable and use it in the message and pass that one to the constructor of theUnknownHttpStatusCodeException