Update StreamUtils drain and emptyInput to use JDK builtins - #28961
Closed
kilink wants to merge 1 commit into
Closed
Update StreamUtils drain and emptyInput to use JDK builtins#28961kilink wants to merge 1 commit into
kilink wants to merge 1 commit into
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Update StreamUtils.drain to use InputStream.transferTo with a null OutputStream. This avoids allocating buffers for cases where the supplied InputStream has an optimized transferTo method (e.g., ByteArrayInputStream and FileInputStream). Additionally, update StreamUtils.emptyInput to simply call InputStream.nullInputStream.
kilink
force-pushed
the
stream-utils-drain-empty-input
branch
from
August 16, 2022 17:09
590ea9d to
646540f
Compare
Contributor
|
There are a few more similar opportunities in StreamUtils:
|
Contributor
Author
There's already a PR for that here: #27702 |
bclozel
added
in: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update StreamUtils.drain to use InputStream.transferTo with a null OutputStream. This avoids allocating buffers for cases where the supplied InputStream has an optimized transferTo method (e.g., ByteArrayInputStream and FileInputStream).
Additionally, update StreamUtils.emptyInput to simply call InputStream.nullInputStream.