Polish CorsConfiguration#33650
Closed
khyojun wants to merge 1 commit intospring-projects:mainfrom
khyojun:main
Closed
Polish CorsConfiguration#33650khyojun wants to merge 1 commit intospring-projects:mainfrom khyojun:main
CorsConfiguration#33650khyojun wants to merge 1 commit intospring-projects:mainfrom
khyojun:main
Conversation
- The * symbol was already handled as a constant, but the / symbol was not. Handling this as a constant will improve readability. - Additionally, the * symbol was replaced in other parts of the code, but it was not replaced in OriginPattern, which caused some confusion. It seems necessary to replace it there as well.
|
@khyojun Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@khyojun Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sdeleuze
added
in: web
sdeleuze
changed the title
CorsConfiguration
Contributor
|
Thanks for your contribution, I only merged the replacement of |
Contributor
Author
|
@sdeleuze "As a student, this is my first time contributing to open source, so I'm a bit unsure! In this case, does this mean I've also contributed to the Spring code? I'm asking because it's my first experience, and I'm so excited!" |
Contributor
|
Yes, you did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes & Considerations