Add more settings to Consumer in PulsarProperties - #223
Merged
Conversation
cbornet
force-pushed
the
more-consumer-props
branch
3 times, most recently
from
November 19, 2022 03:17
043fd0f to
3b2f505
Compare
onobc
suggested changes
Nov 19, 2022
onobc
left a comment
onobc
left a comment
Contributor
There was a problem hiding this comment.
@cbornet looks good. Thanks for getting these config properties all in parity w/ the available client properties. I had one minor test suggestion https://github.com/spring-projects-experimental/spring-pulsar/pull/223/files#r1027036740 - but other than that LGTM.
cbornet
force-pushed
the
more-consumer-props
branch
from
November 19, 2022 09:55
dce6502 to
1b8050d
Compare
onobc
approved these changes
Nov 19, 2022
onobc
approved these changes
Nov 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.