Skip to content

Include UsernameNotFoundException in BadCredentialsException - #16512

Merged
jzheaux merged 1 commit into
spring-projects:mainfrom
big-cir:fix/include-username-not-found-exception
Jun 2, 2025
Merged

Include UsernameNotFoundException in BadCredentialsException#16512
jzheaux merged 1 commit into
spring-projects:mainfrom
big-cir:fix/include-username-not-found-exception

Conversation

@big-cir

@big-cir big-cir commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Overview

  • Preserve UsernameNotFoundException as cause in BadCredentialsException to improve debuggability during authentication failures.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 31, 2025
@jzheaux jzheaux self-assigned this Feb 3, 2025

@jzheaux jzheaux left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience on this one, @big-cir! I've left my feedback inline.

@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 29, 2025
@jzheaux jzheaux added this to the 7.0.x milestone May 29, 2025
@big-cir
big-cir force-pushed the fix/include-username-not-found-exception branch 3 times, most recently from 4297f2a to c368ace Compare May 31, 2025 02:54
Closes spring-projectsgh-16496

Signed-off-by: dae won <eodnjs01477@gmail.com>
@big-cir
big-cir force-pushed the fix/include-username-not-found-exception branch from c368ace to a8b7adc Compare May 31, 2025 02:56
@jzheaux jzheaux modified the milestones: 7.0.x, 7.0.0-M1 Jun 2, 2025
@jzheaux
jzheaux merged commit 9654e51 into spring-projects:main Jun 2, 2025
@jzheaux

jzheaux commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

Thanks, @big-cir, this is now merged into main.

@big-cir
big-cir deleted the fix/include-username-not-found-exception branch June 3, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants