Update Ont-Time-Token Login Docs - #18368
Open
hardikxk wants to merge 1 commit into
Open
Conversation
Update UriComponentsBuilder method implementation in the given example Signed-off-by: Hardik Kumar <hardikkumarpro0005@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Author
|
well since #19274 got merged even though this PR was open since December of last year when I raised that issue first and (waiting for triage) since then, its better to just close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update UriComponentsBuilder method implementation in the given example
Description
This pull request updates the
One-Time Token Logindocumentation to correct an outdated method call. The current documentation suggests usingUriComponentsBuilder.fromHttpUrl(), which is no longer available in the Spring Framework 7.0.x API.The example has been updated to use
UriComponentsBuilder.fromUriString(request.getRequestURL().toString()), which is the correct and supported implementation for capturing the absolute request URL in modern Spring Security environments.Motivation
Following the current documentation leads to compilation errors (
Cannot resolve method 'fromHttpUrl') for users attempting to implement the new One-Time Token (OTT) feature. Correcting this ensures a smooth onboarding experience for passwordless authentication.Related Issue
Closes gh-18367
email: hardikkumarpro0005@gmail.com
Signed-off-by: Hardik Kumar