Skip to content

Miscalculation of car charging window size #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 1 commit into from
Dec 28, 2023
Merged

Miscalculation of car charging window size #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4944,12 +4944,12 @@ def plan_car_charging(self, car_n, low_rates):
kwh = self.car_charging_rate[car_n] * hours

kwh_add = kwh * self.car_charging_loss
kwh_left = self.car_charging_limit[car_n] - car_soc
kwh_left = max(self.car_charging_limit[car_n] - car_soc, 0)

# Clamp length to required amount (shorten the window)
if kwh_add > kwh_left:
percent = kwh_left / kwh_add
length = int((length * percent) / 5 + 2.5) * 5
length = min(int(((length * percent) / 5) + 2.5) * 5, end - start)
end = start + length
hours = length / 60
kwh = self.car_charging_rate[car_n] * hours
Expand Down