Skip to content

Fix crash with calculate soc only #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 2 commits into from
Jan 3, 2024
Merged

Fix crash with calculate soc only #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e1476
Fix crash with calculate soc only
springfall2008 Jan 3, 2024
a767a9a
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7891,8 +7891,7 @@ def optimise_all_windows(self, load_minutes_step, load_minutes_step10, pv_foreca
# Log set of charge and discharge windows
if self.calculate_best_charge:
self.log(
"Best charge windows in price group {} best_metric {} best_cost {} metric_keep {} windows {}".format(
price,
"Best charge windows best_metric {} best_cost {} metric_keep {} windows {}".format(
self.dp2(best_metric),
self.dp2(best_cost),
self.dp2(best_keep),
Expand All @@ -7902,8 +7901,7 @@ def optimise_all_windows(self, load_minutes_step, load_minutes_step10, pv_foreca

if self.calculate_best_discharge:
self.log(
"Best discharge windows in price group {} best_metric {} best_cost {} metric_keep {} windows {}".format(
price,
"Best discharge windows best_metric {} best_cost {} metric_keep {} windows {}".format(
self.dp2(best_metric),
self.dp2(best_cost),
self.dp2(best_keep),
Expand Down
4 changes: 2 additions & 2 deletions docs/apps-yaml.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,9 @@ To make planned car charging more accurate, configure the following items in `ap
Multiple cars can be planned with Predbat, in which case you should set **num_cars** in `apps.yaml` to the number of cars you want to plan

- **car_charging_limit**, **car_charging_planned**, **car_charging_battery_size** and **car_charging_soc** must then be a list of values (i.e. 2 entries for 2 cars)

- If you have Intelligent Octopus then Car 0 will be managed by the Octopus Energy integration, if its enabled

- Each car will have it's own Home Assistant slot sensor created e.g. **binary_sensor.predbat_car_charging_slot_1**,
SOC planning sensor e.g **predbat.car_soc_1** and **predbat.car_soc_best_1** for car 1

Expand Down