Skip to content

Do not set reserve while actively charging #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 1 commit into from
Jan 6, 2024
Merged

Do not set reserve while actively charging #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8795,6 +8795,7 @@ def execute_plan(self):
if self.set_charge_freeze and (self.charge_limit_best[0] == self.reserve):
if self.set_soc_enable and self.set_reserve_enable and self.set_reserve_hold:
inverter.disable_charge_window()

disabled_charge_window = True
status = "Freeze charging"
status_extra = " target {}%".format(inverter.soc_percent)
Expand Down Expand Up @@ -8997,7 +8998,7 @@ def execute_plan(self):
)
)

# If we should set reserve?
# If we should set reserve during charging
if self.set_soc_enable and self.set_reserve_enable and not setReserve:
if self.charge_limit_best and (self.minutes_now < inverter.charge_end_time_minutes) and (self.minutes_now >= inverter.charge_start_time_minutes):
# Compute limit to account for freeze setting
Expand All @@ -9010,7 +9011,7 @@ def execute_plan(self):
limit = self.charge_limit_percent_best[0]

# Only set the reserve when we reach the desired percent
if inverter.soc_percent > limit:
if (inverter.soc_percent > limit) or (not disabled_charge_window):
self.log("Adjust reserve to default as SOC {} % is above target {} %".format(inverter.soc_percent, limit))
inverter.adjust_reserve(0)
else:
Expand Down Expand Up @@ -10625,4 +10626,4 @@ def run_time_loop_balance(self, cb_args):
except Exception as e:
self.log("ERROR: Exception raised {}".format(e))
self.record_status("ERROR: Exception raised {}".format(e))
raise e
raise e