Skip to content

Don't reset charge window going read-only if not controlling it #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 2 commits into from
Jan 6, 2024
Merged

Don't reset charge window going read-only if not controlling it #585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f8c21a
Don't reset charge window going read-only if not controlling it
springfall2008 Jan 6, 2024
a9929d4
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8705,13 +8705,16 @@ def reset_inverter(self):
)
if self.set_charge_window or (self.inverter_needs_reset_force in ["set_read_only", "mode"]):
inverter.adjust_charge_rate(inverter.battery_rate_max_charge * 60.0 * 1000.0)
inverter.disable_charge_window()
if self.set_read_only and self.set_charge_window:
# Only reset charge window if we are no longer controller charge window
inverter.disable_charge_window()
inverter.adjust_battery_target(100.0)
if self.set_charge_window or self.set_discharge_window or (self.inverter_needs_reset_force in ["set_read_only", "mode"]):
inverter.adjust_reserve(0)
if self.set_discharge_window or (self.inverter_needs_reset_force in ["set_read_only", "mode"]):
inverter.adjust_discharge_rate(inverter.battery_rate_max_discharge * 60 * 1000)
inverter.adjust_force_discharge(False)

self.inverter_needs_reset = False
self.inverter_needs_reset_force = ""

Expand Down Expand Up @@ -8795,7 +8798,7 @@ def execute_plan(self):
if self.set_charge_freeze and (self.charge_limit_best[0] == self.reserve):
if self.set_soc_enable and self.set_reserve_enable and self.set_reserve_hold:
inverter.disable_charge_window()

disabled_charge_window = True
status = "Freeze charging"
status_extra = " target {}%".format(inverter.soc_percent)
Expand Down Expand Up @@ -10626,4 +10629,4 @@ def run_time_loop_balance(self, cb_args):
except Exception as e:
self.log("ERROR: Exception raised {}".format(e))
self.record_status("ERROR: Exception raised {}".format(e))
raise e
raise e