Skip to content

Fix issue where inverter skew is falsely reported #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 2 commits into from
Jan 15, 2024
Merged

Fix issue where inverter skew is falsely reported #623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf3e94
Fix issue where inverter skew is falsely reported
springfall2008 Jan 15, 2024
e993cdb
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import os
import yaml

THIS_VERSION = "v7.14.43"
THIS_VERSION = "v7.14.44"
TIME_FORMAT = "%Y-%m-%dT%H:%M:%S%z"
TIME_FORMAT_SECONDS = "%Y-%m-%dT%H:%M:%S.%f%z"
TIME_FORMAT_OCTOPUS = "%Y-%m-%d %H:%M:%S%z"
Expand Down Expand Up @@ -837,19 +837,23 @@ def __init__(self, base, id=0, quiet=False):

# Check inverter time and confirm skew
if self.inverter_time:
tdiff = self.inverter_time - self.base.now_utc
# Fetch current time again as it may have changed since we run this inverter update
local_tz = pytz.timezone(self.base.get_arg("timezone", "Europe/London"))
now_utc = datetime.now(local_tz)

tdiff = self.inverter_time - now_utc
tdiff = self.base.dp2(tdiff.seconds / 60 + tdiff.days * 60 * 24)
if not quiet:
self.base.log("Invertor time {} AppDaemon time {} difference {} minutes".format(self.inverter_time, self.base.now_utc, tdiff))
self.base.log("Invertor time {} AppDaemon time {} difference {} minutes".format(self.inverter_time, now_utc, tdiff))
if abs(tdiff) >= 5:
self.base.log(
"WARN: Invertor time is {} AppDaemon time {} this is {} minutes skewed, Predbat may not function correctly, please fix this by updating your inverter or fixing AppDaemon time zone".format(
self.inverter_time, self.base.now_utc, tdiff
self.inverter_time, now_utc, tdiff
)
)
self.base.record_status(
"Invertor time is {} AppDaemon time {} this is {} minutes skewed, Predbat may not function correctly, please fix this by updating your inverter or fixing AppDaemon time zone".format(
self.inverter_time, self.base.now_utc, tdiff
self.inverter_time, now_utc, tdiff
),
had_errors=True,
)
Expand Down