Skip to content

Issue with reserve max causing flip/flop charging at 100% #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 2 commits into from
Jan 30, 2024
Merged

Issue with reserve max causing flip/flop charging at 100% #668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
422ca1f
Issue with reserve max causing flip/flop charging at 100%
springfall2008 Jan 30, 2024
467e267
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9216,7 +9216,13 @@ def execute_plan(self):
status = "Freeze charging"
status_extra = " target {}%".format(inverter.soc_percent)
else:
if self.set_soc_enable and self.set_reserve_enable and self.set_reserve_hold and ((inverter.soc_percent + 1) >= self.charge_limit_percent_best[0]):
if (
self.set_soc_enable
and self.set_reserve_enable
and self.set_reserve_hold
and ((inverter.soc_percent + 1) >= self.charge_limit_percent_best[0])
and (inverter.reserve_max >= inverter.soc_percent)
):
status = "Hold charging"
inverter.disable_charge_window()
disabled_charge_window = True
Expand Down