Skip to content

Debug output fixes #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 2 commits into from
Jan 30, 2024
Merged

Debug output fixes #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fb8902
Debug output fixes
springfall2008 Jan 30, 2024
4eb89b9
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8253,7 +8253,7 @@ def optimise_all_windows(self, load_minutes_step, load_minutes_step10, pv_foreca
self.best_soc_max,
self.dp2(best_metric),
self.dp2(best_cost),
self.charge_limit_best,
self.calc_percent_limit(self.charge_limit_best),
)
)
else:
Expand Down Expand Up @@ -8333,7 +8333,7 @@ def optimise_all_windows(self, load_minutes_step, load_minutes_step10, pv_foreca
self.dp2(best_cost),
self.dp2(best_keep),
self.time_abs_str(self.end_record + self.minutes_now),
self.window_as_text(self.charge_window_best, self.charge_limit_best, ignore_min=True),
self.window_as_text(self.charge_window_best, self.calc_percent_limit(self.charge_limit_best), ignore_min=True),
)
)

Expand Down Expand Up @@ -8964,7 +8964,7 @@ def calculate_plan(self, recompute=True):

self.end_record = self.forecast_minutes
# Show best windows
self.log("Best charge window {}".format(self.window_as_text(self.charge_window_best, self.charge_limit_best)))
self.log("Best charge window {}".format(self.window_as_text(self.charge_window_best, self.charge_limit_percent_best)))
self.log("Best discharge window {}".format(self.window_as_text(self.discharge_window_best, self.discharge_limits_best)))

# Created optimised step data
Expand Down Expand Up @@ -10110,7 +10110,7 @@ def fetch_inverter_data(self):
self.charge_limit_percent = self.calc_percent_limit(self.charge_limit)
self.publish_charge_limit(self.charge_limit, self.charge_window, self.charge_limit_percent, best=False)

self.log("Base charge window {}".format(self.window_as_text(self.charge_window, self.charge_limit)))
self.log("Base charge window {}".format(self.window_as_text(self.charge_window, self.charge_limit_percent)))
self.log("Base discharge window {}".format(self.window_as_text(self.discharge_window, self.discharge_limits)))

def manual_select(self, config_item, value):
Expand Down