Skip to content

Detect GE inverter in calibration mode, fix to previous charge/discharge rate code #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
springfall2008 merged 3 commits into from
Feb 4, 2024
Merged

Detect GE inverter in calibration mode, fix to previous charge/discharge rate code #717

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1310915
Detect GE inverter in calibration mode, fix to previous charge/discha…
springfall2008 Feb 4, 2024
75c5e4e
Calibration mode to also reset charge/discharge rate
springfall2008 Feb 4, 2024
eb8c390
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions apps/predbat/predbat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,10 @@ def self_test(self, minutes_now):
self.base.log(f"======= INVERTER CONTROL SELF TEST START - REST={self.rest_api} ========")
self.adjust_battery_target(99)
self.adjust_battery_target(100)
self.adjust_charge_rate(215)
self.adjust_charge_rate(self.battery_rate_max_charge)
self.adjust_discharge_rate(220)
self.adjust_discharge_rate(self.battery_rate_max_discharge)
self.adjust_reserve(100)
self.adjust_reserve(6)
self.adjust_reserve(4)
Expand Down Expand Up @@ -1002,6 +1006,7 @@ def __init__(self, base, id=0, quiet=False):
self.pv_power = 0
self.load_power = 0
self.rest_api = None
self.in_calibration = False

self.inverter_type = self.base.get_arg("inverter_type", "GE", indirect=False)

Expand Down Expand Up @@ -1052,6 +1057,10 @@ def __init__(self, base, id=0, quiet=False):
# XXX: Weird workaround for battery reporting wrong capacity issue
self.base.log("WARN: REST data reports Battery Capacity kWh as {} but nominal indicates {} - using nominal".format(self.soc_max, self.nominal_capacity))
self.soc_max = self.nominal_capacity
soc_force_adjust = self.rest_data["raw"]["invertor"]["soc_force_adjust"]
if soc_force_adjust and soc_force_adjust != "0" and soc_force_adjust != "7":
self.in_calibration = True
self.log("WARN: Inverter is in calibration mode, Predbat will not function correctly and will be disabled")
self.soc_max *= self.base.battery_scaling

# Max battery rate
Expand Down Expand Up @@ -1856,7 +1865,7 @@ def adjust_charge_rate(self, new_rate, notify=True):
else:
entity = self.base.get_entity(self.base.get_arg("charge_rate", indirect=False, index=self.id))
# Write
self.write_and_poll_value("charge_rate", entity, new_rate, fuzzy=(self.battery_rate_max_charge / 25))
self.write_and_poll_value("charge_rate", entity, new_rate, fuzzy=(self.battery_rate_max_charge * MINUTE_WATT / 25))
if self.inv_output_charge_control == "current":
self.set_current_from_power("charge", new_rate)

Expand Down Expand Up @@ -1904,7 +1913,7 @@ def adjust_discharge_rate(self, new_rate, notify=True):
self.rest_setDischargeRate(new_rate)
else:
entity = self.base.get_entity(self.base.get_arg("discharge_rate", indirect=False, index=self.id))
self.write_and_poll_value("discharge_rate", entity, new_rate, fuzzy=(self.battery_rate_max_discharge / 25))
self.write_and_poll_value("discharge_rate", entity, new_rate, fuzzy=(self.battery_rate_max_discharge * MINUTE_WATT / 25))

if self.inv_output_charge_control == "current":
self.set_current_from_power("discharge", new_rate)
Expand Down Expand Up @@ -2649,7 +2658,7 @@ def rest_setChargeRate(self, rate):
# time.sleep(10)
self.rest_data = self.rest_runAll(self.rest_data)
new = self.rest_data["Control"]["Battery_Charge_Rate"]
if abs(new - rate) < (self.battery_rate_max_charge / 25):
if abs(new - rate) < (self.battery_rate_max_charge * MINUTE_WATT / 25):
self.base.log("Inverter {} set charge rate {} via REST successful on retry {}".format(self.id, rate, retry))
return True

Expand All @@ -2669,7 +2678,7 @@ def rest_setDischargeRate(self, rate):
# time.sleep(10)
self.rest_data = self.rest_runAll(self.rest_data)
new = self.rest_data["Control"]["Battery_Discharge_Rate"]
if abs(new - rate) < (self.battery_rate_max_discharge / 25):
if abs(new - rate) < (self.battery_rate_max_discharge * MINUTE_WATT / 25):
self.base.log("Inverter {} set discharge rate {} via REST successful on retry {}".format(self.id, rate, retry))
return True

Expand Down Expand Up @@ -9158,6 +9167,9 @@ def balance_inverters(self):
for id in range(num_inverters):
inverter = Inverter(self, id, quiet=True)
inverter.update_status(minutes_now, quiet=True)
if inverter.in_calibration:
self.log("Inverter {} is in calibration mode, not balancing".format(id))
return
inverters.append(inverter)

out_of_balance = False # Are all the SOC % the same
Expand Down Expand Up @@ -9683,6 +9695,15 @@ def execute_plan(self):
if self.set_read_only:
status = "Read-Only"
continue
# Inverter is in calibration mode
if inverter.in_calibration:
status = "Calibration"
inverter.adjust_charge_rate(inverter.battery_rate_max_charge * MINUTE_WATT)
inverter.adjust_discharge_rate(inverter.battery_rate_max_discharge * MINUTE_WATT)
inverter.adjust_battery_target(100.0)
inverter.adjust_reserve(0)
self.log("Inverter is in calibration mode, not executing plan and enabling charge/discharge at full rate.")
break

resetDischarge = False
if (not self.set_discharge_during_charge) or (not self.car_charging_from_battery):
Expand Down