Swap navigation queries from exists()->first() to just first()#182
Draft
haydngreatnews wants to merge 3 commits intomainfrom
Draft
Swap navigation queries from exists()->first() to just first()#182haydngreatnews wants to merge 3 commits intomainfrom
haydngreatnews wants to merge 3 commits intomainfrom
Conversation
This should reduce the number of queries we make on two fronts -- first, the exists does a `select 1 ...`, which doesn't contribute to the cache, and so the `.first()` call then makes a second query to get actual data. There were also a bunch of places where we were repeatedly calling `first` to get a related item, which might have been doing multiple queries -- but this way is also a but more readable
haydngreatnews
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce the number of queries we make on two fronts -- first, the
exists does a
select 1 ..., which doesn't contribute to the cache, and so the.first()call then makes a second query to get actual data. There were also abunch of places where we were repeatedly calling
firstto get a related item,which might have been doing multiple queries -- but this way is also a but more
readable