PR: Some fixes to load project configuration files correctly#13146
Merged
Conversation
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-07-01 00:36:00 UTC |
Member
Author
|
Pinging @mrclary about this one. |
…s://github.com/andfoy/python-language-server.git external-deps/python-language-server subrepo: subdir: "external-deps/python-language-server" merged: "bbf1f4722" upstream: origin: "https://github.com/andfoy/python-language-server.git" branch: "fix_multiple_workspace_config" commit: "bbf1f4722" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
…rtup This way we can remove a spurious call because the project's path (which needs to be passed to the PyLS) is already saved in our preferences.
This was not allowing us to associate our temporary file (temp.py) to other workspaces besides the default one.
ccordoba12
force-pushed
the
load-workspace-config
branch
from
507433e to
b28a557
Compare
Contributor
|
@ccordoba12 , Thanks for taking care of this. |
Member
Author
|
No problem. It was a lot of work, but the functionality was horribly broken. So, thanks a lot to you too for letting us know that before releasing 4.1.4. |
…r/python-language-server.git external-deps/python-language-server subrepo: subdir: "external-deps/python-language-server" merged: "5fa7ae915" upstream: origin: "https://github.com/palantir/python-language-server.git" branch: "develop" commit: "5fa7ae915" git-subrepo: version: "0.4.1" origin: "https://github.com/ingydotnet/git-subrepo" commit: "a04d8c2"
Member
Author
|
This is finally ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR (which contains a lot of fixes on the PyLS side) is now possible to load
~/.config/pycodestyleor/path/to/project/pycodestyle.cfgand have those settings prevail over the ones defined by the user in Spyder.I also updated the PyLS version to
>=0.34.0,<0.35.0to have the fixes we need for this.Fixes #13110.