PR: Improve code and UX concerning Qt WebEngine#25733
PR: Improve code and UX concerning Qt WebEngine#25733rear1019 wants to merge 1 commit intospyder-ide:masterfrom
Conversation
| # https://github.com/spyder-ide/spyder/pull/ | ||
| # 22196#issuecomment-2189377043 | ||
| if PluginClass.REQUIRE_WEB_WIDGETS and ( | ||
| not WEBENGINE or |
There was a problem hiding this comment.
qtpy.QtWebEngineWidgets.WEBENGINE and its usage in Spyder is confusing: qtpy used to define it to differentiate between Qt WebEngine and Qt WebKit. This is also the way it is used in most places in Spyder. With WebKit gone/not used by Spyder, the differentiation between WebEngine/WebKit can be removed. I can do this as part of this PR (when the PR is accepted).
Concerning the usage in the sense "is WebEngine available", see the new spyder.app.utils.HAVE_WEBENGINE.
| if PluginClass.REQUIRE_WEB_WIDGETS and ( | ||
| not WEBENGINE or | ||
| not HAVE_WEBENGINE or | ||
| self._cli_options.no_web_widgets |
There was a problem hiding this comment.
With the fallback to plaintext implemented by this PR, the command line argument --no-web-widgets can be removed, deprecated or made an no-operation.
| LOG_PATH = get_conf_path(CONF_SECTION) | ||
| DISABLE_ACTIONS_WHEN_HIDDEN = False | ||
| REQUIRE_WEB_WIDGETS = True | ||
| REQUIRE_WEB_WIDGETS = False |
There was a problem hiding this comment.
This PR implements a fallback to plain text when Qt WebEngine is not available.
1 participant
Description of Changes
This PR aims to improve code and UX concerning Qt WebEngine. The initial version of the PR implements a fall back to plain text in the Help plugin when Qt WebEngine is not available. If accepted, some clean-up changes will be added.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
rear1019