SQLite 3.26.0 update#260
Closed
brody2consult wants to merge 3 commits into
Closed
Conversation
brody2consult
referenced
this pull request
in brody2consult/sqlite-evcustom-browser-memory-storage-ext-free
Jan 4, 2019
from the following branch: - <https://github.com/brodybits/sql.js/tree/sqlite-3.26.0-build> (as proposed in <https://github.com/kripken/sql.js/pull/260>)
Member
|
Thank you for the pull request ! However, I would like to have #255 merged first. |
Author
|
Any timeframe when we can finish #255 and apply this update then? This can be a blocker for people who develop and test with both SQL.js and SQLite 3.26.0. |
Author
|
I would favor including SQLite 3.26.0 first, which is a security update, since @255 seems to be a breaking change. |
Member
|
What are the security implications of not having 3.26 for SQL.js ? I read the security announcement you gave a link to, and it does not seem clear it affects sql.js... |
4 tasks
Contributor
|
I've upgraded to the latest Sqlite 3.28 in #255. |
Contributor
|
Is this PR valid after #255 @brodybits or does that solve your issue? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-s WASM=0to disable wasm inMakefilec/sqlite3.cwith SQLite3.26.0This update is needed for a major client. I hope to see it applied asap.
resolves #258