fix copyfrom methods on interface not matching generated methods #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods generated for `copyfrom` queries correctly define a slice of inputs on the function signatures, but the interface code that was generated did not. Thus, the interface was not usable when any query used `copyfrom`. This merge request updates the interface code template to correctly use `.Arg.SlicePair` when building the interface. Signed-off-by: Alex Dulin <alex@morningconsult.com>
kyleconroy
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods generated for
copyfromqueries correctly define a sliceof inputs on the function signatures, but the interface code that was
generated did not. Thus, the interface was not usable when any query
used
copyfrom. This merge request updates the interface code templateto correctly use
.Arg.SlicePairwhen building the interface.Signed-off-by: Alex Dulin alex@morningconsult.com