SQLite: Adds a few more tests, fixes DROP TABLE #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
approved these changes
Feb 18, 2022
Collaborator
kyleconroy
left a comment
kyleconroy
left a comment
There was a problem hiding this comment.
One small comment, but I'm going to merge.
| @@ -1 +1,3 @@ | |||
| CREATE TABLE venues (name text); | |||
|
|
|||
| CREATE TABLE IF NOT EXISTS arenas (name text PRIMARY KEY, location text, size int NOT NULL) WITHOUT ROWID; | |||
Collaborator
There was a problem hiding this comment.
Can we create a separate test for create table without rowID? I don't think it applies to any other engine than SQLite
Contributor
Author
There was a problem hiding this comment.
Will do, I was mostly trying to exercise the parser and make sure it didn't complain, I don't think these extra options have any impact on anything that sqlc cares about.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to fill out SQLite end-to-end data.