feat(codegen): Insert comments in interfaces#1451
Closed
sbres wants to merge 1 commit intosqlc-dev:mainfrom
Closed
feat(codegen): Insert comments in interfaces#1451sbres wants to merge 1 commit intosqlc-dev:mainfrom
sbres wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
- Add docstring to interfaces to improve IDE method documentation
4521360 to
bb25ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1400 I've added the comments into the interface generation the same way it's done for the auto-generated methods.
I've compiled sqlc using
make sqlc-dev. And ran it on this repo https://github.com/sbres/sqlc_example.The generated output went from:
To
I was not able to run the full suite of tests.