feat(sqlite) Adds support for column aliases and function arguments #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PadraigK
commented
Feb 23, 2022
PadraigK
commented
- Support for SQLite column aliases
- Support for SQLite function arguments
- Adds SQLite versions for various tests that passed without changes
- Adds a new func_match_types end to end test for postgresql and mysql to illustrate Incorrect aggregate function variant selected from catalog #1450
PadraigK
commented
Feb 24, 2022
| type AuthorPagesRow struct { | ||
| Author string | ||
| NumBooks int64 | ||
| TotalPages float64 |
Contributor
Author
There was a problem hiding this comment.
This should be an int64 once #1450 is fixed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.