Refactor struct name #1560
Closed
Refactor struct name #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am working on the errors. |
Contributor
Author
|
I have removed the unit tests. |
Contributor
Author
|
This pull request in now not relevant as the updates it proposed have already been handled by #1595. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
func StructName(name string, settings *plugin.Settings) stringtofunc StructName(name, rename string) stringto make it easier to isolate during test. It only needs renamed string from thesettings *plugin.Settings, thus thee is no need to provide the entiresettings *plugin.Settings.In addition
strings.Title(s string)from the Go strings package has been deprecated in Go v1.18. Therefore, we should instead usecases.Title(language.English).String("myString")from the cases package.