improve mysql container support for testing #1711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakobera
changed the title
kyleconroy
requested changes
Jun 26, 2022
Collaborator
kyleconroy
left a comment
kyleconroy
left a comment
There was a problem hiding this comment.
Looks like you managed to pull in some unrelated changes. Can you rebase?
* update devcontainer go image to 1.18-bullseye to match go.mod * use mysql/mysql-server image to support arm based machine like M1 Mac * set `MYSQL_ROOT_HOST: '%'` to allow access from any host * https://dev.mysql.com/doc/mysql-installation-excerpt/8.0/en/docker-mysql-more-topics.html#docker_var_mysql-root-host
hakobera
force-pushed
the
improve-mysql-container-support
branch
from
c16055d to
06439be
Compare
Contributor
Author
|
@kyleconroy sorry, I fetched upstream unexpectedly. I rebased to latest main branch and pushed. |
kyleconroy
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MYSQL_ROOT_HOST: '%'to allow access from any hostlinkssection to avoid DNS lookup failure