-
Notifications
You must be signed in to change notification settings - Fork 984
Add pg_tables and pg_views to catalog #1748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
64cfb3b
pg-gen: add tables from pg_tables and pg_views
skabbes cff0fcf
wasm: do not send pg_catalog tables to wasm plugins
skabbes a849638
pggen: recommit generated files
skabbes f02d6c8
test: add end-to-end test for pg_timezone_names
skabbes c873256
pggen: distinguish between direct and aggregated args
skabbes f18530e
pggen: recommit generated files
skabbes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyleconroy These columns previously weren't ordered at all, so I think the existing output in pg_catalog.go is kind of in almost 'random' order. I ordered by basically every column here, not because it is important - but to keep the output stable between runs of
sqlc-pg-gen.