Skip to content

Only enable postgresql support when cgo is enabled as it is required #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Feb 14, 2023
Merged

Only enable postgresql support when cgo is enabled as it is required #2068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/engine/postgresql/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//go:build !windows
// +build !windows
//go:build !windows && cgo
// +build !windows,cgo

package postgresql

Expand Down Expand Up @@ -3120,7 +3120,7 @@ func convertNode(node *pg.Node) ast.Node {

case *pg.Node_BooleanTest:
return convertBooleanTest(n.BooleanTest)

case *pg.Node_CallStmt:
return convertCallStmt(n.CallStmt)

Expand Down
4 changes: 2 additions & 2 deletions internal/engine/postgresql/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//go:build !windows
// +build !windows
//go:build !windows && cgo
// +build !windows,cgo

package postgresql

Expand Down
4 changes: 2 additions & 2 deletions internal/engine/postgresql/parse_windows.go → internal/engine/postgresql/parse_disabled.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//go:build windows
// +build windows
//go:build windows || !cgo
Copy link
Contributor Author

@anuraaga anuraaga Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to rename this file since _windows was implicitly causing the file to only be used on windows, independent of the build tag

// +build windows !cgo

package postgresql

Expand Down
4 changes: 2 additions & 2 deletions internal/engine/postgresql/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//go:build !windows
// +build !windows
//go:build !windows && cgo
// +build !windows,cgo

package postgresql

Expand Down