Skip to content

test: Skip tests if required plugins are missing #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 2 commits into from
Feb 22, 2023
Merged

test: Skip tests if required plugins are missing #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b41dcf3
test: Skip tests if required plugins are missing
kyleconroy Feb 22, 2023
22b94d3
Fix failing test
kyleconroy Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions internal/endtoend/endtoend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"context"
"encoding/json"
"os"
osexec "os/exec"
"path/filepath"
"strings"
"testing"
Expand Down Expand Up @@ -102,6 +103,13 @@ func TestReplay(t *testing.T) {
args := parseExec(t, path)
expected := expectedStderr(t, path)

if args.Process != "" {
_, err := osexec.LookPath(args.Process)
if err != nil {
t.Skipf("executable not found: %s %s", args.Process, err)
}
}

switch args.Command {
case "diff":
err = cmd.Diff(ctx, cmd.Env{ExperimentalFeatures: true}, path, "", &stderr)
Expand Down Expand Up @@ -144,6 +152,9 @@ func cmpDirectory(t *testing.T, dir string, actual map[string]string) {
if filepath.Base(path) == "sqlc.json" {
return nil
}
if filepath.Base(path) == "exec.json" {
return nil
}
if strings.Contains(path, "/kotlin/build") {
return nil
}
Expand Down Expand Up @@ -199,6 +210,7 @@ func expectedStderr(t *testing.T, dir string) string {

type exec struct {
Command string `json:"command"`
Process string `json:"process"`
}

func parseExec(t *testing.T, dir string) exec {
Expand Down
3 changes: 3 additions & 0 deletions internal/endtoend/testdata/process_plugin_sqlc_gen_json/exec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"process": "sqlc-gen-json"
}