Skip to content

fix(sqlite) fix EXISTS operator #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kyleconroy merged 1 commit into from
Jun 20, 2023
Merged

fix(sqlite) fix EXISTS operator #2334

kyleconroy merged 1 commit into from
Jun 20, 2023

Conversation

@hakobera
Copy link
Contributor

@hakobera hakobera commented Jun 17, 2023

Fix #2321. This is regression which introduced by #2274, so this PR revert unnecessary change.

  • revert unnecessary in convertInSelectNode function, which include In but it's not the function to handle IN operator
  • add EXISTS and NOT EXISTS test case for SQLite
  • add debug log for easy to identity issue

@kyleconroy kyleconroy merged commit 0ed414a into sqlc-dev:main Jun 20, 2023
@hakobera hakobera deleted the fix/sqlite-exists-operator branch June 20, 2023 16:53
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@hakobera
fix(sqlite) fix EXISTS operator (sqlc-dev#2334)
2501d0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EXISTS causes panic

2 participants

@hakobera @kyleconroy