fix(engine/sqlite): fix table_alias rules #2465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed rules to conform to fallback directive behavior fix sqlc-dev#2271
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
* fix(engine/sqlite): fix table_alias rules changed rules to conform to fallback directive behavior fix sqlc-dev#2271 * test: update endtoend * Update parser code --------- Co-authored-by: Kyle Conroy <kyle@sqlc.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2271
In the current grammar, the LEFT part of LEFT JOIN was recognized as table_alias.
lemon has a fallback directive that treats it as a KEYWORD and treats it as an identifier if parsing fails.
ref: https://sqlite.org/src/doc/trunk/doc/lemon.html#pfallback
The rule has been modified to match this behavior.
Add a table_alias_fallback rule that also includes KEYWORD to lower the precedence to match SQLite's behavior.