Skip to content

Fix issue with public schema creation #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PlatosCodes wants to merge 1 commit into from
Closed

Fix issue with public schema creation #2495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/sql/catalog/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,15 @@ func (c *Catalog) getSchema(name string) (*Schema, error) {
}

func (c *Catalog) createSchema(stmt *ast.CreateSchemaStmt) error {
if stmt.Name == nil {
if *stmt.Name == "" {
return fmt.Errorf("create schema: empty name")
}
if _, err := c.getSchema(*stmt.Name); err == nil {
if !stmt.IfNotExists {
// If the schema is 'public' and IfNotExists is false,
// we want to ignore the error and proceed as if IfNotExists was true.
if *stmt.Name == "public" && !stmt.IfNotExists {
return nil
} else {
return sqlerr.SchemaExists(*stmt.Name)
}
}
Expand Down