Added ISNULL return type#631
Merged
kyleconroy merged 4 commits intosqlc-dev:masterfrom Jul 28, 2020
torrayne:master
Merged
Conversation
added 3 commits
July 28, 2020 11:01
emit_empty_slices was misspelled as emit_emptly_slices
Author
|
Would it be beneficial for me to go through all the functions and add their return types? |
Collaborator
|
Thanks!
At this time, no. The mysql package is deprecated. All current and future MySQL work is happening in the engine/dolphin. For functions, we're going to automatically generate the type signatures. See the work done for PostgreSQL in #550 |
Collaborator
|
I wrote up a bit more about the deprecation of the mysql package #633 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
I've added
isnullto returnintas that's whatmysqldoes.MYSQL does understand
trueandfalseso maybe it should returnboolinstead ofint. I'm not very familiar with howfunctionReturnTypeis used so I don't know if that's an option.