Support multi-column NOT IN expressions - #776
Open
sya-ri wants to merge 1 commit into
Open
Conversation
sya-ri
force-pushed
the
agent/composite-not-in-bind
branch
from
July 28, 2026 06:10
cd71231 to
39be764
Compare
sya-ri
marked this pull request as ready for review
July 28, 2026 06:10
This was referenced Jul 28, 2026
griffio
approved these changes
Jul 28, 2026
griffio
left a comment
Collaborator
There was a problem hiding this comment.
I have tested against SqlDelight locally and appears to work correctly.
I can't merge here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOTin multi-columnINexpressionsWhy
SQLDelight can model row-value
IN, but the base grammar rejected the symmetricNOT INform. That blocks composite collection-bind support and otherwise valid row-value queries.Validation
./gradlew :core:test --tests '*AnsiSqlTests*multi-column-select-in-where*'\n\n## Checklist\n- [x] Added a regression fixture\n- [x] Preserved existingINbehavior\n- [x] UpdatedCHANGELOG.md