Fix AccessibilityContainer behaviour when it contains a UICollectionView or UITableView#566
Conversation
kyleve
left a comment
kyleve
left a comment
There was a problem hiding this comment.
Yay, glad to see this one landing!
johnnewman-square
left a comment
johnnewman-square
left a comment
There was a problem hiding this comment.
These changes look good! I left a few questions in the integration branch.
meherkasam-square
force-pushed
the
meher/a11y-elements
branch
6 times, most recently
from
f861053 to
8c8b649
Compare
| extension UIView { | ||
| func recursiveAccessibleSubviews() -> [Any] { | ||
| subviews.flatMap { subview -> [Any] in | ||
| func accessibilityElements( |
There was a problem hiding this comment.
We're now duplicating this same logic in three places here, within market, and in the snapshots.
It would be nice to have this (or an equivalent) as one of the canonical functions available in our forthcoming a11y toolbox. @soroushsq
There was a problem hiding this comment.
In that case, do we expect that Blueprint will depend on the accessibility toolbox?
There was a problem hiding this comment.
Given the more recent development of modifying the sort function to be more specific to how Blueprint behaves, we might need to maintain at two separate versions of frameSort.
meherkasam-square
force-pushed
the
meher/a11y-elements
branch
from
8c8b649 to
cf95d9c
Compare
meherkasam-square
force-pushed
the
meher/a11y-elements
branch
from
cf95d9c to
cda9d7f
Compare
…iew or UITableView
meherkasam-square
force-pushed
the
meher/a11y-elements
branch
from
cda9d7f to
ab88ba2
Compare
5 participants
No description provided.