Reverting the change to remove accessibility traits on the AttributedLabel#597
Merged
johnnewman-square merged 1 commit intomainfrom Nov 4, 2025
Merged
Reverting the change to remove accessibility traits on the AttributedLabel#597johnnewman-square merged 1 commit intomainfrom
johnnewman-square merged 1 commit intomainfrom
Conversation
…ibilityTraits is nil. From 9cba469
RoyalPineapple
approved these changes
Nov 4, 2025
Collaborator
|
Any idea why this was changed in the first place? |
Contributor
Author
I believe the code was originally changed to fix a case where setting |
johnnewman-square
added a commit
that referenced
this pull request
Nov 4, 2025
* main: Reverting the change to remove accessibility traits on the AttributedLabel (#597)
Merged
johnnewman-square
added a commit
that referenced
this pull request
Nov 13, 2025
## What's Changed * Reverting the change to remove accessibility traits on the AttributedLabel by @johnnewman-square in #597 * Adding safe area edge detection for the scrollableAxes behavior by @johnnewman-square in #596 **Full Changelog**: 6.3.1...6.4.0
maxg-square
added a commit
that referenced
this pull request
Nov 27, 2025
* main: chore: Release 6.5.0 (#600) refactor: Migrate Accessibility Infrastructure from Market Design System (#593) chore: Release 6.4.0 (#599) Adding safe area edge detection for the scrollableAxes behavior (#596) Reverting the change to remove accessibility traits on the AttributedLabel (#597) Update changelog for 6.3.1 release (#591) Fix warnings in Xcode 26 (#589) Apply empty accessibility traits to AttributedLabel if supplied traits is nil Bump rexml from 3.3.9 to 3.4.2
maxg-square
added a commit
that referenced
this pull request
Nov 27, 2025
* maxg/cache_1_equivalency: chore: Release 6.5.0 (#600) refactor: Migrate Accessibility Infrastructure from Market Design System (#593) chore: Release 6.4.0 (#599) Adding safe area edge detection for the scrollableAxes behavior (#596) Reverting the change to remove accessibility traits on the AttributedLabel (#597) Update changelog for 6.3.1 release (#591) Fix warnings in Xcode 26 (#589) Apply empty accessibility traits to AttributedLabel if supplied traits is nil Bump rexml from 3.3.9 to 3.4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #590. During integration testing, the original change caused KIF failures while searching for labels with the
staticTexttrait. The work to audit the failures and make necessary code changes has been ticketed here.This revert allows the changes in #596 to be fully tested.