Merged
Conversation
kyleve
reviewed
Aug 4, 2023
| ### Changed | ||
|
|
||
| - `SwipeAction` property names have been updated to better reflect what they're for. `Completion` also now takes in a more descriptive enum, instead of a boolean, to make reading callsites clearer. Eg, `completion(.expandActions)` instead of `completion(true)`. | ||
| - `KeyboardObserverDelegate` now provides `UIView.AnimationCurve` instead of `UIView.AnimationOptions`. |
kyleve
reviewed
Aug 4, 2023
| // KeyboardObserver.swift | ||
| // ListableUI | ||
| // | ||
| // Created by Kyle Van Essen on 2/16/20. |
kyleve
reviewed
Aug 4, 2023
|
|
||
| var endingFrame : CGRect = .zero | ||
| @available(iOS 16.1, *) | ||
| var screen: UIScreen { |
Collaborator
There was a problem hiding this comment.
Is this intermediary useful? Can we not just do this in init?
Member
Author
There was a problem hiding this comment.
AFAIK, you can't have stored properties that are marked with @available. So to keep the public API as accurate as possible I'm using that private optional UIScreen property for storage. There might be a cleaner way to do this but I didn't come across anything when I looked.
kyleve
approved these changes
Aug 4, 2023
Collaborator
kyleve
left a comment
kyleve
left a comment
There was a problem hiding this comment.
Couple small things, otherwise LGTM!
Member
Author
|
@kyleve The notification screen handling was updated in 27d578d to match the revised Market implementation (https://github.com/squareup/market/pull/6826). |
kyleve
approved these changes
Sep 1, 2023
kyleve
added a commit
that referenced
this pull request
Sep 20, 2023
* origin/main: Release 13.0.0 (#504) Update KeyboardObserver (#499) CONV-1435: Gravity layout frame change fix - Before: Layout gravity doesn't take into account frame changes. For example, when the orientation changes the scroll position (relative to the bottom) changes - After: Layout gravity takes frame changes into account so the when the frame changes the scroll position relative to the bottom remains unchanged Release 12.0.0 (#501) CONV-1435: Add scroll indicator insets to customScrollViewInsets (#500) CONV-1435: Gravity layout - Adds a new Chat App demo and a new behavior called verticalLayoutGravity. When verticalLayoutGravity is set to bottom, scrolling works the way you would expect for a messaging app. expose onKeyboardFrameWillChange on ListProperties onKeyboardFrameWillChange: Improve CHANGELOG, DocC CONV-1435: Custom keyboard adjustment mode - Adds a .custom KeyboardAdjustmentMode to fully customize inset behavior remove contentOffset from isContentScrollable calculation, improve comment Add ListView#isContentScrollable property - Add this property to ListView. It will be used in conjunction with upcoming so-called gravity scrolling changes to workaround an animation issue with paging Update CI script to reference the `xcodesorg/made/xcodes` package for installing simulator runtimes. (#494)
kyleve
added a commit
that referenced
this pull request
Nov 19, 2023
…rovements * origin/main: (123 commits) Update CHANGELOG.md (#508) Revert "Supplementary Tracking Fixes (#433)" Revert "Force layout before appear, to avoid animated updates (#505)" Force layout before appear, to avoid animated updates (#505) Update workaround versions (#506) Fix supplementary view + contained first responder reuse issue (#507) Supplementary Tracking Fixes (#433) Release 13.0.0 (#504) Update KeyboardObserver (#499) CONV-1435: Gravity layout frame change fix - Before: Layout gravity doesn't take into account frame changes. For example, when the orientation changes the scroll position (relative to the bottom) changes - After: Layout gravity takes frame changes into account so the when the frame changes the scroll position relative to the bottom remains unchanged Release 12.0.0 (#501) CONV-1435: Add scroll indicator insets to customScrollViewInsets (#500) CONV-1435: Gravity layout - Adds a new Chat App demo and a new behavior called verticalLayoutGravity. When verticalLayoutGravity is set to bottom, scrolling works the way you would expect for a messaging app. expose onKeyboardFrameWillChange on ListProperties onKeyboardFrameWillChange: Improve CHANGELOG, DocC CONV-1435: Custom keyboard adjustment mode - Adds a .custom KeyboardAdjustmentMode to fully customize inset behavior remove contentOffset from isContentScrollable calculation, improve comment Add ListView#isContentScrollable property - Add this property to ListView. It will be used in conjunction with upcoming so-called gravity scrolling changes to workaround an animation issue with paging Update CI script to reference the `xcodesorg/made/xcodes` package for installing simulator runtimes. (#494) Swipe Action Updates (#489) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
KeyboardObserverto match the more recent implementation we use elsewhere.Changes include:
UIView.AnimationCurveinstead ofUIView.AnimationOptionsListViewchanges:UIViewPropertyAnimatorinstead ofUIView.animatewhen responding to keyboard notifications.KeyboardFrameWillChangeCallbacknow receives theUIView.AnimationCurveinstead ofUIView.AnimationOptionsNote: This implementation
Checklist
Please do the following before merging:
Mainsection.