Merged
Conversation
apramana
reviewed
Sep 28, 2023
|
|
||
| [versions] | ||
| agp = "7.1.0" | ||
| agp = "7.3.1" |
There was a problem hiding this comment.
Updating to AGP 8 should resolve the lint job failure, but that will also require use of JDK 17.
Contributor
Author
There was a problem hiding this comment.
The lint issue was easy enough to fix, since it's just a sample app.
vRallev
approved these changes
Sep 28, 2023
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip |
Contributor
Author
There was a problem hiding this comment.
Technically, but it's a pain in the butt when you're doing Gradle things and want to click into the source or even just read the javadoc.
Since Gradle's not being bundled into the release, it doesn't do any harm to just improve the devx a little bit.
The AGP update becomes necessary in order to resolve: ``` Could not determine the dependencies of task ':sample:app:testDebugUnitTest'. > Could not create task ':sample:app:processDebugResources'. > Cannot use @TaskAction annotation on method IncrementalTask.taskAction$gradle_core() because interface org.gradle.api.tasks.incremental.IncrementalTaskInputs is not a valid parameter to an action method. ```
RBusarow
force-pushed
the
rick/gradle-agp
branch
from
dc1422c to
98f1f63
Compare
vRallev
approved these changes
Sep 28, 2023
Contributor
Author
|
I would like to replace the references to the deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AGP update becomes necessary in order to resolve: