[Bugfix] Incremental compilation via constructor parameter change.#755
[Bugfix] Incremental compilation via constructor parameter change.#755Laimiux wants to merge 1 commit intosquare:mainfrom
Conversation
4e62e5d to
1e541b1
Compare
1e541b1 to
b76faf3
Compare
|
@Laimiux Thanks for taking care of the fix! I also ran it in the sample project and on my own project with different scenarios, and it indeed fixes the problematic behaviour. @JoelWilcox could you please share the vision of the Anvil team on this fix? I see that it can solve the problem, but as @Laimiux said, it may not be applicable for all the use-cases in complex projects. |
➕ Thanks for taking a stab at this @Laimiux!
Due to the nature of the incremental compilation issues and how easy it is for regressions to happen in new areas even if we fix some cases, we're making sure we get appropriate integration test coverage in place before moving forward with related fixes. @RBusarow is currently working on that and applying the fix described in #693 (comment). |
|
Thanks again for the PR; closing now in favor of #836 |
Attempting to fix #754, it would be good for someone with a better understanding of compiler plugins to take a look at this. I was able to test various scenarios successfully, but they might not be exhaustive.