Support KSP in BindsMethodValidator by IlyaGulya · Pull Request #831 · square/anvil

For those three tests, what you wanna do is enable the KSP validator on the first compilation and then just use the regular dagger processing on the subsequent compilation. Hoping that could work?

Sidenote - there are some related changes I've made in #830 to support Dagger's new behavior in 2.48, but you're welcome to cherry-pick those into this PR since they sorta go together and I can update my PR after this is in

ZacSweers · 2023-12-26T23:23:38Z

eh actually the more I think about it, the more I think it'll be smoother for me to just update that PR and get this one through first. I can manage any conflicts. Just know that it's there :)

IlyaGulya · 2023-12-27T04:55:06Z

eh actually the more I think about it, the more I think it'll be smoother for me to just update that PR and get this one through first. I can manage any conflicts. Just know that it's there :)

Ok, now I will fix those three tests and add a test for #750, after that I will wait for your PR to be merged 🙂

IlyaGulya · 2023-12-27T12:24:47Z

@ZacSweers regarding the #750 - I've added test which is correctly passes in KSP mode.
However, I've spent about 4 hours already trying to fix it in Embedded mode and I think it will require another 4-8 hours to get any success =)
Will Embedded mode be replaced by KSP mode or it will stay and I should fix this behavior?

IlyaGulya · 2023-12-27T15:01:41Z

Nevermind, I've fixed #750 🙁

compiler-utils/src/main/java/com/squareup/anvil/compiler/internal/reference/ClassReference.kt

ZacSweers · 2023-12-28T18:05:52Z

if it's not too difficult, do you think it's possible to split out the fix for #750 to a separate PR first? Might make this easier to review

IlyaGulya · 2023-12-29T09:59:59Z

if it's not too difficult, do you think it's possible to split out the fix for #750 to a separate PR first? Might make this easier to review

Sure!

IlyaGulya · 2023-12-31T14:04:17Z

@ZacSweers I've extracted #750 fix to #833

ZacSweers · 2024-02-12T21:06:28Z

Let's start reviewing this once #833 is in and this branch is updated. Suspect there will be a decent amount of overlap :)

ZacSweers · 2024-02-17T01:16:54Z

@IlyaGulya ping me when you've pulled latest main and we can start review here!

IlyaGulya · 2024-02-18T13:19:24Z

@ZacSweers done!
I've also removed the receiver parameter validation because extension functions are no longer supported.

ZacSweers

Nice work

ZacSweers · 2024-02-20T20:38:11Z

compiler/src/test/java/com/squareup/anvil/compiler/dagger/BindsMethodValidatorTest.kt

  }

+  @Test
+  fun `binding inside interface is valid`() {


ZacSweers · 2024-02-20T20:38:34Z

compiler/src/test/java/com/squareup/anvil/compiler/dagger/BindsMethodValidatorTest.kt

    @Language("kotlin") vararg sources: String,
    previousCompilationResult: JvmCompilationResult? = null,
    enableDagger: Boolean = useDagger,
+    forceEmbeddedMode: Boolean = false,


Can you add a small comment explaining why we need this for posterity?

I'm not sure how to explain it in a comment.
I've added this flag to fix tests according to your suggestion: #831 (comment)

Just a simple comment like "Used to enable the dagger compiler even in KSP mode, which is necessary for some multi-round tests"

ZacSweers · 2024-02-20T20:39:13Z

compiler/src/main/java/com/squareup/anvil/compiler/codegen/ksp/KspUtil.kt

    }
 }
+
+private fun requireSingleInjectConstructor(


ZacSweers · 2024-02-20T20:43:40Z

compiler/src/main/java/com/squareup/anvil/compiler/codegen/dagger/BindsMethodValidator.kt

+            .resolveSuperTypesExcludingAny()
+            .toList()
+
+        if (returnType !in parameterSuperTypes) {


Can we use KSP's built-in assignability check? KSType.isAssignableFrom(...)

Sure, I did not know about this api. Will fix that =)

ZacSweers · 2024-02-21T15:05:01Z

compiler/src/main/java/com/squareup/anvil/compiler/codegen/ksp/KspUtil.kt

+  )
+}
+
+internal inline fun <reified T> Resolver.getAnnotatedSymbols(): Sequence<KSAnnotated> {


This requires all these classes to be on the KSP classpath. This could cause unexpected errors if this processor is run on a source set that doesn't contain them, and we should gracefully degrade in this case. This is why we usually use the fqcn. No need to fix here as we depend directly on these annotations in the compiler artifact anyway, but just a note

ZacSweers · 2024-02-21T15:06:33Z

compiler/src/test/java/com/squareup/anvil/compiler/dagger/BindsMethodValidatorTest.kt

    @Language("kotlin") vararg sources: String,
    previousCompilationResult: JvmCompilationResult? = null,
    enableDagger: Boolean = useDagger,
+    forceEmbeddedMode: Boolean = false,


Just a simple comment like "Used to enable the dagger compiler even in KSP mode, which is necessary for some multi-round tests"

ZacSweers · 2024-03-14T19:24:15Z

Haven't forgotten about this, we just had to revert the embedded impl temporarily due to issues :/. Will revisit once that one is in again, unless you want to rebase this one

IlyaGulya · 2024-03-19T15:02:46Z

@ZacSweers you mean this revert? 5a04d60
I haven't got time to fix that issue yet, unfortunately.
But I can rebase this PR if it will help, for sure 🙂

IlyaGulya · 2024-03-27T04:48:27Z

@ZacSweers done 🙂

ZacSweers

Sorry for taking so long on this, appreciate your patience!

IlyaGulya commented Dec 27, 2023

View reviewed changes

compiler-utils/src/main/java/com/squareup/anvil/compiler/internal/reference/ClassReference.kt Outdated Show resolved Hide resolved

IlyaGulya force-pushed the feature/ksp/binds-method-validator branch from dc8c9d7 to 8f0cdf6 Compare December 27, 2023 17:56

IlyaGulya force-pushed the feature/ksp/binds-method-validator branch from 8f0cdf6 to e153081 Compare December 31, 2023 14:02

IlyaGulya force-pushed the feature/ksp/binds-method-validator branch from e153081 to d37d6ca Compare December 31, 2023 14:06

IlyaGulya force-pushed the feature/ksp/binds-method-validator branch from d37d6ca to 52e0a97 Compare January 18, 2024 09:12

IlyaGulya force-pushed the feature/ksp/binds-method-validator branch from 52e0a97 to 593833a Compare January 27, 2024 06:50

IlyaGulya force-pushed the feature/ksp/binds-method-validator branch 3 times, most recently from fbc6d57 to f087463 Compare February 18, 2024 13:18

ZacSweers reviewed Feb 20, 2024

View reviewed changes

ZacSweers reviewed Feb 21, 2024

View reviewed changes

ZacSweers approved these changes Feb 22, 2024

View reviewed changes

IlyaGulya added 2 commits March 26, 2024 17:17

Support KSP in BindsMethodValidator

7eaf81a

Fix tests requiring dagger compilation in BindsMethodValidator

7095f29

IlyaGulya added 2 commits March 26, 2024 17:18

use KSP built-in assignability check

695bdd5

explain forceEmbeddedMode parameter in BindsMethodValidatorTest

d062920

IlyaGulya force-pushed the feature/ksp/binds-method-validator branch from c4d1f71 to d062920 Compare March 26, 2024 12:19

ZacSweers approved these changes Apr 3, 2024

View reviewed changes

Merge branch 'main' into feature/ksp/binds-method-validator

85a28c4

ZacSweers enabled auto-merge (squash) April 3, 2024 17:17

ZacSweers merged commit e5919f2 into square:main Apr 3, 2024

IlyaGulya deleted the feature/ksp/binds-method-validator branch April 4, 2024 03:32

gildor mentioned this pull request Apr 8, 2024

Support KSP in factory generation #751

Closed

15 tasks

Conversation

IlyaGulya commented Dec 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IlyaGulya commented Dec 26, 2023

Uh oh!

IlyaGulya commented Dec 26, 2023

Uh oh!

ZacSweers commented Dec 26, 2023

Uh oh!

ZacSweers commented Dec 26, 2023

Uh oh!

IlyaGulya commented Dec 27, 2023

Uh oh!

IlyaGulya commented Dec 27, 2023

Uh oh!

IlyaGulya commented Dec 27, 2023

Uh oh!

Uh oh!

ZacSweers commented Dec 28, 2023

Uh oh!

IlyaGulya commented Dec 29, 2023

Uh oh!

IlyaGulya commented Dec 31, 2023

Uh oh!

ZacSweers commented Feb 12, 2024

Uh oh!

ZacSweers commented Feb 17, 2024

Uh oh!

IlyaGulya commented Feb 18, 2024

Uh oh!

ZacSweers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZacSweers commented Mar 14, 2024

Uh oh!

IlyaGulya commented Mar 19, 2024

Uh oh!

IlyaGulya commented Mar 27, 2024

Uh oh!

ZacSweers left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

IlyaGulya commented Dec 26, 2023 •

edited

Loading

CLAassistant commented Dec 26, 2023 •

edited

Loading