binding extension properties to Gradle properties#851
Merged
Conversation
RBusarow
force-pushed
the
rick/gradle-property-conventions
branch
2 times, most recently
from
e0a2f3b to
7ee26c8
Compare
This change makes it so that all of Anvil's existing configuration options can be set via a `gradle.properties` or a `-P_______` command line option.
For any setting, Anvil take the first non-null value out of:
1. Settings in the Gradle DSL:
```kotlin
anvil {
generateDaggerFactories.set(true)
}
```
3. Properties set via the command line like:
```sh
./gradlew build -Pcom.squareup.anvil.generateDaggerFactories=true
```
4. Properties specified in a project-level, root-project-level, or `~/.gradle/`-level `gradle.properties`:
```properties
com.squareup.anvil.generateDaggerFactories = true
```
5. Hard-coded default values (never null)
Practically speaking, this makes it possible to *locally* feature-toggle things (like the upcoming incremental fix) without touching a project's build logic.
RBusarow
force-pushed
the
rick/gradle-property-conventions
branch
from
7ee26c8 to
980c538
Compare
JoelWilcox
reviewed
Jan 16, 2024
gradle-plugin/src/gradleTest/java/com/squareup/anvil/plugin/AnvilExtensionTest.kt
Outdated
Show resolved
Hide resolved
gradle-plugin/src/gradleTest/java/com/squareup/anvil/plugin/AnvilExtensionTest.kt
Outdated
Show resolved
Hide resolved
RBusarow
force-pushed
the
rick/gradle-property-conventions
branch
from
6818af1 to
e40306c
Compare
JoelWilcox
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so that all of Anvil's existing configuration options can be set via a
gradle.propertiesor a-P_______command line option.For any setting, Anvil take the first non-null value out of:
anvil { generateDaggerFactories.set(true) }~/.gradle/-levelgradle.properties:com.squareup.anvil.generateDaggerFactories = truePractically speaking, this makes it possible to locally feature-toggle things (like the upcoming incremental fix) without touching a project's build logic.