Skip to content

add metrics endpoint for csi #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniruddha2000 wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −0
Open

add metrics endpoint for csi #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e0b688
add metrics endpoint for csi
aniruddha2000 Jun 17, 2026
5ad727d
add metrics address in csi driver deployment arg
aniruddha2000 Jun 17, 2026
9d925bb
add variable in metric port
aniruddha2000 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ne/charts/stackit-blockstorage-csi-driver/templates/deployment-csi-driver-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ spec:
{{- end }}
- --v=3
- --provide-node-service=false
- --metrics-address=:{{ .Values.config.metricsPort }}
env:
- name: CSI_ENDPOINT
value: unix://{{ .Values.socketPath }}/csi.sock
Expand All @@ -74,6 +75,10 @@ spec:
- name: healthz
containerPort: 9808
protocol: TCP
- containerPort: {{ .Values.config.metricsPort }}
hostPort: {{ .Values.config.metricsPort }}

@nschad nschad Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hostPort: {{ .Values.config.metricsPort }}

Why do we need the hostPort?

@aniruddha2000 aniruddha2000 Jun 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/stackitcloud/cloud-provider-stackit/blob/449c3b2295c4bbdd5f09d219bf731fc8bcec2ea7/deploy/cloud-controller-manager/deployment.yaml#L45-L48 wanted to keep similar patern

@nschad nschad Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No please just create a service and don't expose the port to the node

name: metrics
protocol: TCP
livenessProbe:
httpGet:
path: /healthz
Expand Down
2 changes: 2 additions & 0 deletions charts/internal/seed-controlplane/charts/stackit-blockstorage-csi-driver/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
replicas: 1
config:
metricsPort: 9090
Comment thread
aniruddha2000 marked this conversation as resolved.
podAnnotations: {}
kubernetesVersion: 1.30.0
prefix: stackit-blockstorage
Expand Down