feat: make root disk of bastion configurable#182
Open
nschad wants to merge 4 commits into
Open
Conversation
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
size/L
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
hown3d
reviewed
Jun 19, 2026
hown3d
left a comment
hown3d
left a comment
Member
There was a problem hiding this comment.
Thanks for this change!
just a small nit :)
|
|
||
| const ( | ||
| // RootDiskSize is the default root disk size for the bastion server | ||
| RootDiskSize = int64(25) |
Member
There was a problem hiding this comment.
nit: rename to DefaultRootDiskSize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Our "coreos" image size was recently increased to 13GiB (see upstream PR or flatcar/Flatcar#1917). In order to make the bastion controller a bit more flexible I've leverage the provider-specific
CloudprofileConfigto allow for customRootDiskSizes.Additionally we moved the status check immediately after
reconcileServeras the VM creation is async and we should first check if the server was created properly before doing further operations on said server.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: