Allow specifying empty list for CIDRSliceFlag #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicentepinto98
approved these changes
Mar 21, 2024
vicentepinto98
suggested changes
Mar 21, 2024
Contributor
vicentepinto98
left a comment
vicentepinto98
left a comment
There was a problem hiding this comment.
Are you sure this will work for all services that have the --acl flag? I think some of them do not accept empty list
Contributor
Author
|
As discussed, the flag logic should always allow setting an empty slice I tested with all services that use this flag and the ones that do not accept an empty list validate it in the API and the error response is clear enough, so I think we don't need to validate it in the CLI |
vicentepinto98
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify an empty CIDR slice by setting the flag to
"".E.g.
stackit <service> instance update <instance ID> --acl ""sets the ACLs of the instance to the empty list.This makes the custom flag
CIDRSliceFlaghave the same behaviour for empty values as the more generic and defaultStringSliceflag type