Skip to content

UX Improvements: fixes and improvements #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DiogoFerrao merged 10 commits into from
Apr 3, 2024
Merged

UX Improvements: fixes and improvements #190

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
437afa7
add default to project list
DiogoFerrao Mar 28, 2024
15b574d
project list: improve implementation, add testing
DiogoFerrao Mar 28, 2024
36c974b
minor improvements to code
DiogoFerrao Apr 2, 2024
22308b1
fix linting
DiogoFerrao Apr 2, 2024
b6a3223
change keyring testing
DiogoFerrao Apr 2, 2024
678e854
address comments in PR
DiogoFerrao Apr 2, 2024
5be2e43
address PR comments
DiogoFerrao Apr 3, 2024
20c1281
generate docs
DiogoFerrao Apr 3, 2024
856cb19
Update internal/pkg/args/args.go
DiogoFerrao Apr 3, 2024
4063e65
fix linting
DiogoFerrao Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor improvements to code
  • Loading branch information
@DiogoFerrao
DiogoFerrao committed Apr 3, 2024
commit 36c974bd98193f46aee6d77e2d98e931225dd833
10 changes: 3 additions & 7 deletions internal/cmd/project/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,11 @@ func parseInput(cmd *cobra.Command) (*inputModel, error) {
}
}

parentId := flags.FlagToStringPointer(cmd, parentIdFlag)
projectIdLike := flags.FlagToStringSliceValue(cmd, projectIdLikeFlag)
member := flags.FlagToStringPointer(cmd, memberFlag)

return &inputModel{
GlobalFlagModel: globalFlags,
ParentId: parentId,
ProjectIdLike: projectIdLike,
Member: member,
ParentId: flags.FlagToStringPointer(cmd, parentIdFlag),
ProjectIdLike: flags.FlagToStringSliceValue(cmd, projectIdLikeFlag),
Member: flags.FlagToStringPointer(cmd, memberFlag),
CreationTimeAfter: creationTimeAfter,
Limit: limit,
PageSize: pageSize,
Expand Down
6 changes: 0 additions & 6 deletions internal/cmd/project/list/list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ var testClient = &resourcemanager.APIClient{}
var testParentId = uuid.NewString()
var testProjectIdLike = uuid.NewString()
var testCreationTimeAfter = "2023-01-01T00:00:00Z"
var authUserEmail, _ = auth.GetAuthField(auth.USER_EMAIL)

func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
flagValues := map[string]string{
Expand Down Expand Up @@ -258,11 +257,6 @@ func TestParseInput(t *testing.T) {
}

func TestBuildRequest(t *testing.T) {
keyring.MockInit()
err := auth.SetAuthField(auth.USER_EMAIL, "test@test.com")
if err != nil {
t.Fatalf("Failed to set auth user email: %v", err)
}

authUserEmail, err := auth.GetAuthField(auth.USER_EMAIL)
if err != nil {
Expand Down