Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
implement function to create default create config
  • Loading branch information
DiogoFerrao committed Apr 17, 2024
commit 38aecfebacd4185393ab9d6921ca7e9cad5f1825
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
}

if model.JobName == nil {
createPayload, err := argusUtils.GetDefaultCreateScrapeConfigPayload(ctx, apiClient)
if err != nil {
return err
}
createPayload := argusUtils.GetDefaultCreateScrapeConfigPayload()
return outputCreateResult(p, createPayload)
} else {
req := buildRequest(ctx, model, apiClient)
Expand Down
19 changes: 17 additions & 2 deletions internal/pkg/services/argus/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"strings"

"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"

"github.com/stackitcloud/stackit-sdk-go/services/argus"
)
Expand Down Expand Up @@ -207,6 +208,20 @@ func GetInstanceName(ctx context.Context, apiClient ArgusClient, instanceId, pro
return *resp.Name, nil
}

func GetDefaultCreateScrapeConfigPayload(ctx context.Context, apiClient ArgusClient) (*argus.CreateScrapeConfigPayload, error) {
return nil, nil
func GetDefaultCreateScrapeConfigPayload() *argus.CreateScrapeConfigPayload {
staticConfigs := []argus.CreateScrapeConfigPayloadStaticConfigsInner{
{
Targets: utils.Ptr([]string{
"url-target",
}),
},
}
return &argus.CreateScrapeConfigPayload{
JobName: utils.Ptr("default-name"),
MetricsPath: utils.Ptr("/metrics"),
Scheme: utils.Ptr("https"),
ScrapeInterval: utils.Ptr("5m"),
ScrapeTimeout: utils.Ptr("2m"),
StaticConfigs: &staticConfigs,
}
}
50 changes: 50 additions & 0 deletions internal/pkg/services/argus/utils/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,31 @@ func fixtureUpdateScrapeConfigPayload(mods ...func(*argus.UpdateScrapeConfigPayl
return payload
}

func fixtureCreateScrapeConfigPayload(mods ...func(*argus.CreateScrapeConfigPayload)) *argus.CreateScrapeConfigPayload {
staticConfigs := []argus.CreateScrapeConfigPayloadStaticConfigsInner{
{
Targets: utils.Ptr([]string{
"url-target",
}),
},
}

payload := &argus.CreateScrapeConfigPayload{
JobName: utils.Ptr("default-name"),
MetricsPath: utils.Ptr("/metrics"),
Scheme: utils.Ptr("https"),
ScrapeInterval: utils.Ptr("5m"),
ScrapeTimeout: utils.Ptr("2m"),
StaticConfigs: &staticConfigs,
}

for _, mod := range mods {
mod(payload)
}

return payload
}

type argusClientMocked struct {
getInstanceFails bool
getInstanceResp *argus.GetInstanceResponse
Expand Down Expand Up @@ -383,5 +408,30 @@ func TestMapToUpdateScrapeConfigPayload(t *testing.T) {

})
}
}

func TestGetDefaultCreateScrapeConfigPayload(t *testing.T) {
tests := []struct {
description string
expectedPayload *argus.CreateScrapeConfigPayload
}{
{
description: "base case",
expectedPayload: fixtureCreateScrapeConfigPayload(),
},
}

for _, tt := range tests {
t.Run(tt.description, func(t *testing.T) {
payload := GetDefaultCreateScrapeConfigPayload()

diff := cmp.Diff(*payload, *tt.expectedPayload,
cmp.AllowUnexported(*tt.expectedPayload),
)
if diff != "" {
t.Fatalf("Data does not match: %s", diff)
}

})
}
}