Skip to content

BUGFIX: fix prompt for enter on Windows #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DiogoFerrao merged 2 commits into from
May 8, 2024
Merged

BUGFIX: fix prompt for enter on Windows #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f18ad38
fix prompt for enter func
DiogoFerrao May 8, 2024
a39068c
update comments
DiogoFerrao May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions internal/pkg/print/print.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,22 +138,15 @@ func (p *Printer) PromptForConfirmation(prompt string) error {

// Prompts the user for confirmation by pressing Enter.
//
// Returns nil only if the user (explicitly) press directly enter.
// Returns ErrAborted if the user press anything else before pressing enter.
// Returns nil if the user presses Enter.
func (p *Printer) PromptForEnter(prompt string) error {
reader := bufio.NewReaderSize(p.Cmd.InOrStdin(), 1)

reader := bufio.NewReader(p.Cmd.InOrStdin())
p.Cmd.PrintErr(prompt)
answer, err := reader.ReadByte()
_, err := reader.ReadString('\n')
if err != nil {
return fmt.Errorf("read user response: %w", err)
}

// ASCII code for Enter (newline) is 10.
if answer == 10 {
return nil
}
return errAborted
return nil
}

// Shows the content in the command's stdout using the "less" command
Expand Down