Skip to content

Load balancer observability-credentials list fixes #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DiogoFerrao merged 1 commit into from
May 10, 2024
Merged

Load balancer observability-credentials list fixes #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions internal/cmd/load-balancer/observability-credentials/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,21 +83,29 @@ func NewCmd(p *print.Printer) *cobra.Command {
return fmt.Errorf("list Load Balancer observability credentials: %w", err)
}
credentialsPtr := resp.Credentials
if credentialsPtr == nil || len(*credentialsPtr) == 0 {
p.Info("No observability credentials found for Load Balancer on project %q\n", projectLabel)
return nil
}

credentials := *credentialsPtr

filterOp, err := getFilterOp(model.Used, model.Unused)
if err != nil {
return err
var credentials []loadbalancer.CredentialsResponse
if credentialsPtr != nil && len(*credentialsPtr) > 0 {
credentials = *credentialsPtr
filterOp, err := getFilterOp(model.Used, model.Unused)
if err != nil {
return err
}
credentials, err = utils.FilterCredentials(ctx, apiClient, credentials, model.ProjectId, filterOp)
if err != nil {
return fmt.Errorf("filter credentials: %w", err)
}
}

credentials, err = utils.FilterCredentials(ctx, apiClient, credentials, model.ProjectId, filterOp)
if err != nil {
return fmt.Errorf("filter credentials: %w", err)
if len(credentials) == 0 {
opLabel := "No "
if model.Used {
opLabel += "used"
} else if model.Unused {
opLabel += "unused"
}
p.Info("%s observability credentials found for Load Balancer on project %q\n", opLabel, projectLabel)
return nil
}

// Truncate output
Expand Down